Merged
Conversation
This includes the removal of the predicate and changes to the `ReconcileAnnotationValue` function. In retrospect, it would have been better if we at the time had changed the `LastHandledReconcileAt` field in the `ReconcileRequestStatus` to something like `LastHandledReconcileRequest`. But I guess this has now become "weirdness due to historical reasons". Signed-off-by: Hidde Beydals <hello@hidde.co>
stefanprodan
approved these changes
Jul 8, 2021
squaremo
approved these changes
Jul 8, 2021
Member
squaremo
left a comment
squaremo
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Thanks Hidde 🍇
hiddeco
added
area/runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the removal of the predicate and changes to the
ReconcileAnnotationValuefunction.In retrospect, it would have been better if we at the time had changed
the
LastHandledReconcileAtfield in theReconcileRequestStatusto something like
LastHandledReconcileRequest. But I guess this hasnow become "weirdness due to historical reasons".
Fixes #120