Conversation
hiddeco
added
area/docs
hiddeco
force-pushed
the
runtime-readme
branch
9 times, most recently
from
99cdd69 to
5190205
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
This makes them part of the public API (and thereby makes them documented) and allows overwrites in case this is ever required. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
runtime-readme
branch
2 times, most recently
from
0dbb9a4 to
78aac43
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
runtime-readme
branch
2 times, most recently
from
6063339 to
15f17a1
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
runtime-readme
branch
2 times, most recently
from
2c9909a to
0b3d042
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
runtime-readme
branch
2 times, most recently
from
6cc9688 to
f7a1d07
Compare
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
scottrigby
approved these changes
Jul 12, 2021
Member
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
Commented offline.
This reads so incredibly well 👏 🏆
lgtm! 🚀
squaremo
approved these changes
Jul 12, 2021
Member
squaremo
left a comment
squaremo
left a comment
There was a problem hiding this comment.
<3 to see this quality of docs; thank you Hidde.
| ## Usage | ||
|
|
||
| To use the packages in your project, import `github.com/fluxcd/pkg/runtime` using `go get` or your dependency manager | ||
| of choice: |
Member
There was a problem hiding this comment.
Is there any option other than go get (or go get, implicitly, via other go commands)?
Member
Author
There was a problem hiding this comment.
I didn't want to imply that using Go Modules is a strict requirement, using e.g. dep ensure should work perfectly fine as well.
Signed-off-by: Hidde Beydals <hello@hidde.co>
This was referenced Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118