oci/auth: Fix ImageRegistryProvider for repo root#434
Merged
Conversation
darkowlzz
force-pushed
the
fix-oci-repo-root-login
branch
from
ab7013d to
faac385
Compare
stefanprodan
approved these changes
Dec 14, 2022
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @darkowlzz 🏅
darkowlzz
force-pushed
the
fix-oci-repo-root-login
branch
from
faac385 to
3228dd6
Compare
When a repository root is provided, ImageRegistryProvider() fails to identify the registry host. The provided name.Reference for repository root is a Tag reference. name.ParseReference(), assumes that that given string is the name and registry host being empty defaults to index.docker.io. ImageRegistryProvider() now takes the full address, in addition to the name.Reference and uses the full address for analysis if there's no "/" in the address, which indicates that it's a repository root. This fixes login with repository root for all the providers, not just AWS. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
fix-oci-repo-root-login
branch
from
3228dd6 to
cb4fdc7
Compare
This was referenced Dec 14, 2022
hiddeco
approved these changes
Dec 14, 2022
This was referenced May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repository root is provided,
ImageRegistryProvider()fails to identify the registry host. The providedname.Referencefor repository root is aTagreference.name.ParseReference(), assumes that that given string is the name and registry host being empty defaults to index.docker.io.ImageRegistryProvider()now takes the full address, in addition to thename.Referenceand uses the full address for analysis if there's no "/" in the address, which indicates that it's a repository root.This fixes login with repository root for all the providers, not just AWS.
Fixes fluxcd/source-controller#951, #429 .
Tested it against EKS with OCI Helm Chart, which was failing before as reported in the above issues.