oci/client: Configureable retry backoff#533
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom May 11, 2023
Merged
Conversation
stefanprodan
added
enhancement
darkowlzz
reviewed
Apr 13, 2023
| func NewLocalClient() *Client { | ||
| options := []crane.Option{ | ||
| crane.WithUserAgent(oci.UserAgent), | ||
| func LocalOptions() []crane.Option { |
Member
There was a problem hiding this comment.
Suggested change
| func LocalOptions() []crane.Option { | |
| func DefaultOptions() []crane.Option { |
| return []crane.Option{ | ||
| crane.WithPlatform(&gcrv1.Platform{ | ||
| Architecture: "flux", | ||
| Architecture: "flusx", |
darkowlzz
reviewed
May 11, 2023
darkowlzz
changed the title
Contributor
|
I've renamed the PR as the change is a general client change and not specific to the push operation. Edit it further if needed for more clarity. |
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
Member
Author
|
@darkowlzz I have updated the PR and added comments for the public functions now. |
stefanprodan
approved these changes
May 11, 2023
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @somtochiama
Member
|
This has been tagged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: fluxcd/flux2#3714
This pull request adds a function to configure the retry backoff on crane option for different OCI operations.
It also removes the
NewLocalClientfunction, adding a functionDefaultOptionsthat returns an array of crane.Options that can be passed intoNewClientto get the same result.