Use registry region to get token for AWS#600
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Jul 6, 2023
Merged
Conversation
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
added
bug
darkowlzz
approved these changes
Jul 6, 2023
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
For now it LGTM!
We'll work on adding corss-region auth integration tests separately.
stefanprodan
approved these changes
Jul 6, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request basically reverts a change introduced in #560 where the region of the instance was used instead of the region from the registry url
Ref: fluxcd/source-controller#1155