Flaky tests in helmchart_controller_test

[pjbgf]

HelmChart is intermittely failing with the error below and may require further investigation:

    Expected success, but got an error:
        <*errors.StatusError | 0x4000dcd7c0>: {
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "Operation cannot be fulfilled on helmcharts.source.toolkit.fluxcd.io \"helmchart-sample-p2zlf\": the object has been modified; please apply your changes to the latest version and try again",
                Reason: "Conflict",
                Details: {
                    Name: "helmchart-sample-p2zlf",
                    Group: "source.toolkit.fluxcd.io",
                    Kind: "helmcharts",
                    UID: "",
                    Causes: nil,
                    RetryAfterSeconds: 0,
                },
                Code: 409,
            },
        }
        Operation cannot be fulfilled on helmcharts.source.toolkit.fluxcd.io "helmchart-sample-p2zlf": the object has been modified; please apply your changes to the latest version and try again

Occurrences:

• https://github.com/fluxcd/source-controller/runs/5216429392?check_suite_focus=true
• https://github.com/fluxcd/source-controller/runs/5187139239?check_suite_focus=true
• https://github.com/fluxcd/source-controller/runs/5186595620?check_suite_focus=true

[pjbgf]

Wondering whether this issue is the result of the server side apply bug: kubernetes/kubernetes#95460

[stefanprodan]

We don't use SSA in SC tests, this is mostly likely solved in the rewrite-dev branch.