Fix: Normalize helm repository url with query params properly#1015
Merged
hiddeco merged 1 commit intofluxcd:mainfrom Feb 15, 2023
Merged
Fix: Normalize helm repository url with query params properly#1015hiddeco merged 1 commit intofluxcd:mainfrom
hiddeco merged 1 commit intofluxcd:mainfrom
Conversation
darkowlzz
reviewed
Feb 1, 2023
darkowlzz
added
bug
hiddeco
reviewed
Feb 1, 2023
darkowlzz
reviewed
Feb 3, 2023
Member
|
This has merge conflicts due to merging of #1001. Also think the commits could be squashed together. |
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
helm-repo-url
branch
from
e2384c4 to
6f0384c
Compare
hiddeco
approved these changes
Feb 15, 2023
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
Looks good to me as well, thank you @somtochiama 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes an issue that causes a 403 forbidden error when trying to download a chart using an Azure SAS token.
This happens because the query parameters get encoded and a trailing slash is added at the end of the query.
Fix: #1018
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com