GA: Promote GitRepository API to source.toolkit.fluxcd.io/v1#1056
Merged
GA: Promote GitRepository API to source.toolkit.fluxcd.io/v1#1056
source.toolkit.fluxcd.io/v1#1056Conversation
stefanprodan
force-pushed
the
gitrepository-v1
branch
2 times, most recently
from
5136db4 to
9a0a899
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
gitrepository-v1
branch
from
9a0a899 to
ef8804c
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
makkes
pushed a commit
to fluxcd/website
that referenced
this pull request
Mar 27, 2023
Signed-off-by: Max Jonas Werner <mail@makk.es>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
makkes
pushed a commit
to fluxcd/website
that referenced
this pull request
Mar 28, 2023
Signed-off-by: Max Jonas Werner <mail@makk.es>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
force-pushed
the
gitrepository-v1
branch
from
15eded4 to
161806b
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Consumers still relying on this should make use of `v1beta2` to facilitate any transition. In addition, remove the `*Implementation` constants for now removed Git implemenations. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
gitrepository-v1
branch
from
161806b to
6bea001
Compare
makkes
reviewed
Mar 28, 2023
Member
makkes
left a comment
makkes
left a comment
There was a problem hiding this comment.
Not sure about the checksum-related changes in here but otherwise lgtm.
hiddeco
force-pushed
the
gitrepository-v1
branch
from
8c8f1c9 to
3e301c6
Compare
darkowlzz
reviewed
Mar 28, 2023
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
A few comments while revising the APIs one last time before v1.
Usage of this field has not been recommended for a long time as it was best-effort based. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Plus a switch from `godoc.org` -> `pkg.go.dev`. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
gitrepository-v1
branch
from
3e301c6 to
8fcfde9
Compare
darkowlzz
reviewed
Mar 28, 2023
darkowlzz
reviewed
Mar 28, 2023
hiddeco
force-pushed
the
gitrepository-v1
branch
from
7379b84 to
1507ebb
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
- Use `kubectl events` in favor of `kubectl get events`. - Remove deleted `URL` field from `Status` examples of `GitRepository` v1. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
gitrepository-v1
branch
from
1507ebb to
f2da9bf
Compare
Member
|
@darkowlzz think I managed to address all your comments. |
Merged
2 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changes
The
GitRepositorykind was promoted from v1beta2 to v1 (GA) and deprecated fields were removed.The common types
Artifact,Conditionsand theSourceinterface were promoted to v1.The
gitrepositories.source.toolkit.fluxcd.ioCRD contains the following versions:Upgrade
The
GitRepositoryv1 API is backwards compatible with v1beta2 with the following exceptions:.spec.gitImplementationwas removed.spec.accessFromwas removed.status.contentConfigChecksumwas removed.status.artifact.checksumwas removed.status.urlwas removed in favor of the absolute.status.artifact.urlTo upgrade from v1beta2, after deploying the new CRD and controller, set
apiVersion: source.toolkit.fluxcd.io/v1in the YAML files that containGitRepositorydefinitions and remove the deprecated fields if any. Bumping the API version in manifests can be done gradually. It is advised to not delay this procedure as the beta versions will be removed after 6 months.Closes: #947