Add proxy support for OCIRepository API#1536
Merged
matheuscscp merged 1 commit intofluxcd:mainfrom Aug 15, 2024
Merged
Conversation
matheuscscp
force-pushed
the
ocirepo-proxy
branch
3 times, most recently
from
33ee8b6 to
2ccda4a
Compare
matheuscscp
changed the title
.spec.proxySecretRef for OCIRepository API
stefanprodan
approved these changes
Jul 12, 2024
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
darkowlzz
reviewed
Jul 15, 2024
matheuscscp
force-pushed
the
ocirepo-proxy
branch
2 times, most recently
from
1020bbb to
ddc34c8
Compare
darkowlzz
reviewed
Jul 18, 2024
matheuscscp
force-pushed
the
ocirepo-proxy
branch
from
ddc34c8 to
9422053
Compare
matheuscscp
force-pushed
the
ocirepo-proxy
branch
5 times, most recently
from
75e2c4f to
1b44a2c
Compare
darkowlzz
reviewed
Aug 13, 2024
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
Thanks for all the proxy tests in OCI artifact verification. The notation related changes also look nice and minimal.
Left a few suggestions in the tests and docs. Everything else looks good to me.
matheuscscp
force-pushed
the
ocirepo-proxy
branch
2 times, most recently
from
0f905bb to
a99476f
Compare
matheuscscp
commented
Aug 14, 2024
darkowlzz
reviewed
Aug 14, 2024
matheuscscp
force-pushed
the
ocirepo-proxy
branch
2 times, most recently
from
a503050 to
c9b27e1
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
ocirepo-proxy
branch
from
c9b27e1 to
03a118a
Compare
darkowlzz
approved these changes
Aug 15, 2024
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for all the work on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1492