Take relative paths in account for Bucket revision#403
Merged
Conversation
This commit changes the checksum method which is used to calculate the revision of a Bucket source, so that the file paths are taken into account and directory structure changes can be observed. Signed-off-by: Hidde Beydals <hello@hidde.co>
98fa2ee to
f5cb441
Compare
stefanprodan
approved these changes
Jul 26, 2021
Contributor
|
Ah, shame, was just about to raise a PR: sata@adc7a6f .. Trying to make it all nice with Ginkgo haha! Next time :) |
Member
Author
Contributor
Member
Author
Yes, that was our experience too, while the Gomega assertion library is excellent (and still in use).
Ah, thanks. I remember having read this but had forgotten about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the checksum method which is used to calculate the
revision of a Bucket source, so that the file paths are taken into
account and directory structure changes can be observed.