Skip to content

Take relative paths in account for Bucket revision#403

Merged
hiddeco merged 1 commit intomainfrom
bucket-revision-path
Jul 26, 2021
Merged

Take relative paths in account for Bucket revision#403
hiddeco merged 1 commit intomainfrom
bucket-revision-path

Conversation

@hiddeco
Copy link
Copy Markdown
Member

@hiddeco hiddeco commented Jul 23, 2021

This commit changes the checksum method which is used to calculate the
revision of a Bucket source, so that the file paths are taken into
account and directory structure changes can be observed.

@hiddeco hiddeco added the area/bucket Bucket related issues and pull requests label Jul 23, 2021
This commit changes the checksum method which is used to calculate the
revision of a Bucket source, so that the file paths are taken into
account and directory structure changes can be observed.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco requested review from squaremo and stefanprodan July 26, 2021 08:57
@hiddeco hiddeco force-pushed the bucket-revision-path branch from 98fa2ee to f5cb441 Compare July 26, 2021 08:58
@hiddeco hiddeco merged commit be5d10e into main Jul 26, 2021
@hiddeco hiddeco deleted the bucket-revision-path branch July 26, 2021 12:01
@sata
Copy link
Copy Markdown
Contributor

sata commented Jul 26, 2021

Ah, shame, was just about to raise a PR: sata@adc7a6f .. Trying to make it all nice with Ginkgo haha! Next time :)

@hiddeco
Copy link
Copy Markdown
Member Author

hiddeco commented Jul 26, 2021

@sata ah, that's too bad. A note for future contributions, we are dropping Ginkgo soon, see the working progress in #361 (specifically 791951b). More extensive tests are however still welcome, even for just the checksum logic. :-)

@sata
Copy link
Copy Markdown
Contributor

sata commented Jul 26, 2021

@sata ah, that's too bad. A note for future contributions, we are dropping Ginkgo soon, see the working progress in #316 (specifically 791951b). More extensive tests are however still welcome, even for just the checksum logic. :-)

I can understand, it felt quite clunky.. I shall remember this.

FYI https://golang.org/doc/go1.16#ioutil :)

@hiddeco
Copy link
Copy Markdown
Member Author

hiddeco commented Jul 26, 2021

I can understand, it felt quite clunky..

Yes, that was our experience too, while the Gomega assertion library is excellent (and still in use).

FYI golang.org/doc/go1.16#ioutil :)

Ah, thanks. I remember having read this but had forgotten about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bucket Bucket related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants