Rewrite HelmRepositoryReconciler to new standards#413
Merged
hiddeco merged 1 commit intoreconcilers-devfrom Aug 12, 2021
Merged
Rewrite HelmRepositoryReconciler to new standards#413hiddeco merged 1 commit intoreconcilers-devfrom
HelmRepositoryReconciler to new standards#413hiddeco merged 1 commit intoreconcilers-devfrom
Conversation
5 tasks
hiddeco
force-pushed
the
helmrepository-reconciler
branch
11 times, most recently
from
89e0cf5 to
37ef4c7
Compare
hiddeco
force-pushed
the
helmrepository-reconciler
branch
4 times, most recently
from
e93f58a to
9a8553a
Compare
This commit rewrites the `HelmRepositoryReconciler` to new standards, while implementing the newly introduced Condition types, and trying to adhere better to Kubernetes API conventions. More specifically it introduces: - Implementation of more explicit Condition types to highlight abnormalities. - Extensive usage of the `conditions` subpackage from `runtime`. - Better and more conflict-resilient (status)patching of reconciled objects using the `patch` subpackage from runtime. - Proper implementation of kstatus' `Reconciling` and `Stalled` conditions. - Refactoring of some Helm elements to make them easier to use within the new reconciler logic. - Integration tests that solely rely on `testenv` and do not use Ginkgo. There are a couple of TODOs marked in-code, these are suggestions for the future and should be non-blocking. In addition to the TODOs, more complex and/or edge-case test scenarios may be added as well. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
helmrepository-reconciler
branch
from
9a8553a to
4963963
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #361
This PR rewrites the
HelmRepositoryReconcilerto new standards,while implementing the newly introduced Condition types, and trying to
adhere better to Kubernetes API conventions.
More specifically it introduces:
abnormalities.
conditionssubpackage fromruntime.objects using the
patchsubpackage from runtime.ReconcilingandStalledconditions.
the new reconciler logic.
testenvand do notuse Ginkgo.
There are a couple of TODOs marked in-code, these are suggestions for
the future and should be non-blocking.
In addition to the TODOs, more complex and/or edge-case test scenarios
may be added as well.