pkg/git: AuthOptions.Validate() test improvements#463
Merged
hiddeco merged 1 commit intofluxcd:git-auth-optsfrom Oct 25, 2021
Merged
pkg/git: AuthOptions.Validate() test improvements#463hiddeco merged 1 commit intofluxcd:git-auth-optsfrom
hiddeco merged 1 commit intofluxcd:git-auth-optsfrom
Conversation
hiddeco
reviewed
Oct 24, 2021
hiddeco
reviewed
Oct 24, 2021
| name: "Valid HTTPS transport", | ||
| opts: AuthOptions{ | ||
| Transport: HTTPS, | ||
| Username: "example", |
Member
There was a problem hiding this comment.
Leaving one of these (HTTP or HTTPS test) would cover an additional test case: HTTP/S transport definition without any config, which should be valid as well.
Adds more test cases for Validate() and an error for unknown transport. Signed-off-by: Sunny <darkowlzz@protonmail.com>
darkowlzz
force-pushed
the
git-auth-opts-patch-1
branch
from
615b2c8 to
ad4e906
Compare
hiddeco
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixturesuffix to a test constantmalformedKeyRing.git-auth-opts.Adds to #462 .