Statically build using musl toolchain and target alpine#558
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Jan 26, 2022
pjbgf:musl-tool-chain
Merged
Statically build using musl toolchain and target alpine#558stefanprodan merged 1 commit intofluxcd:mainfrom pjbgf:musl-tool-chain
stefanprodan merged 1 commit intofluxcd:mainfrom
pjbgf:musl-tool-chain
Conversation
Member
|
@pjbgf I'm not for changing the runtime image in this release. Users will not be able to debug SC nor IAC if we use distroless since there is no shell so they can't see if tmp gets filled, or test egress or list artifacts. Please use Alpine or Bookwarm. |
Member
|
➕ around Stefan's concerns, but no specific preference for an alternative image. |
Member
Author
|
@stefanprodan fair point - I will stick to Alpine as it is less than 10% of the size of bookworm-slim. |
24 tasks
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
alpineas final base image.Although the controller is statically built, we are targeting
alpineto help users debugging the image if they so need/wish.