Conversation
darkowlzz
force-pushed
the
spec-docs-v1beta2
branch
from
3cc06aa to
7be5cdd
Compare
There was a problem hiding this comment.
All kubectl command must contain --field-manager=flux-client-side-apply otherwise kustomize-controller will remove the annotations or any other field that's not in the desired state.
Docs here: https://fluxcd.io/docs/faq/#why-are-kubectl-edits-rolled-back-by-flux
|
I would add |
hiddeco
force-pushed
the
spec-docs-v1beta2
branch
3 times, most recently
from
687af2f to
978d3b0
Compare
hiddeco
force-pushed
the
spec-docs-v1beta2
branch
from
978d3b0 to
0a33829
Compare
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
Sharing some small nits, but overall it is looking really good. 👍
| ToPath string `json:"toPath"` | ||
| } | ||
|
|
||
| // GetFromPath returns the specified FromPath. |
There was a problem hiding this comment.
I feel like func (in *GitRepositoryInclude) FromPath() string and func (in *GitRepositoryInclude) ToPath() string are more intuitive names.
There was a problem hiding this comment.
Fields and methods can not bear the same name.
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @darkowlzz and @hiddeco
PS> I really like the new docs structure, we need to create an issue for rewriting the docs in all controllers based on this PR.
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
Details about the source reference, reconcile strategy and artifact revision value based on the reconcile strategy. Signed-off-by: Sunny <darkowlzz@protonmail.com>
Signed-off-by: Hidde Beydals <hello@hidde.co>
To align with: https://fluxcd.io/docs/faq/#why-are-kubectl-edits-rolled-back-by-flux Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
spec-docs-v1beta2
branch
from
3f867f6 to
971caf9
Compare
5 participants
No description provided.