Add new flag --ssh-hostkey-algos#711
Add new flag --ssh-hostkey-algos#711pjbgf merged 1 commit intofluxcd:mainfrom pjbgf:add-hostkey-flag
--ssh-hostkey-algos#711Conversation
| flag.StringVar(&helmCachePurgeInterval, "helm-cache-purge-interval", "1m", | ||
| "The interval at which the cache is purged. Valid time units are ns, us (or µs), ms, s, m, h.") | ||
| flag.StringSliceVar(&kexAlgos, "ssh-kex-algos", []string{}, | ||
| flag.StringSliceVar(&git.KexAlgos, "ssh-kex-algos", []string{}, |
There was a problem hiding this comment.
Although is technically alright, I wonder if it'd be better to have all the flag vars organized in the same place. This is honestly very trivial, so if you feel like your current change is fine, it's okay by me.
There was a problem hiding this comment.
That was the one thing I wasn't too sure about as well. The motivation for taking this approach was that both vars are not used within main.go, so I did not see much benefit for declaring them there - specially considering that in the feature we may add another one/two similar flags (i.e. --ssh-macs and --ssh-ciphers).
But I am happy to declare the vars within main.go if anyone feels strongly about it.
There was a problem hiding this comment.
We really need to get these flags into docs, like we do for the Flux CLI with https://github.com/fluxcd/flux2/blob/main/cmd/flux/docgen.go
The more flags we add, the harder it gets for users to comprehend Flux global config.
The new flag allow users to set the list of hostkey algorithms to use for ssh connections, enabling them to ensure specific are/aren't used. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
3 participants
The new flag allow users to set the list of hostkey algorithms to use for ssh connections, enabling them to ensure specific are/aren't used.
Fixes #397