Helm reconcilers conditions and test improvements

[souleb]

HelmRepository_OCI reconcilers to make to retry on failure

The setupRegistryServer has been refactored to take into account #690
reviews.

Signed-off-by: Soule BA soule@weave.works

[souleb]

the darwin-amd64 test failed with

--- FAIL: TestCheckoutStrategyForImplementation_Auth (3.38s)
    --- FAIL: TestCheckoutStrategyForImplementation_Auth/libgit2_SSH_clone (1.46s)
        strategy_test.go:117: 
            Unexpected error:
                <*fmt.wrapError | 0xc00007c460>: {
                    msg: "unable to fetch remote 'ssh://git@localhost:49894/bar/test-reponame': SSH could not read data: Error waiting on socket",
                    err: <*git.GitError | 0xc00007c440>{
                        Message: "SSH could not read data: Error waiting on socket",
                        Class: 23,
                        Code: -1,
                    },
                }
                unable to fetch remote 'ssh://git@localhost:49894/bar/test-reponame': SSH could not read data: Error waiting on socket
            occurred

I don't have the right to restart it.

[makkes]

@souleb I just learned about https://fluxcd.io/docs/contributing/flux/#format-of-the-commit-message so let's follow the commit message format described there.

[hiddeco]

I don't have the right to restart it.

I said some magical words to make it restart.

[darkowlzz]

LGTM!