This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Merged
Conversation
jpellizzari
force-pushed
the
helm-releases
branch
2 times, most recently
from
5944825 to
0bd6257
Compare
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
jpellizzari
force-pushed
the
helm-releases
branch
from
0bd6257 to
9fa6f62
Compare
squaremo
reviewed
Apr 13, 2021
Member
squaremo
left a comment
squaremo
left a comment
There was a problem hiding this comment.
I don't understand enough to judge code changes, but I tried it locally and it works well enough :-)
pkg/rpc/clusters/clusters.proto
Outdated
| message Source { | ||
| string name = 1; | ||
| string url = 2; | ||
| string url = 2; |
Member
There was a problem hiding this comment.
Suggested change
| string url = 2; | |
| string url = 2; |
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
Signed-off-by: Jordan Pellizzari <jordan@weave.works>
jpellizzari
force-pushed
the
helm-releases
branch
from
9d47267 to
547c239
Compare
|
This may be user error, but if I navigate to and away from the sources tab I loose my context (top right) :
|
Collaborator
Author
I have seen that as well. Probably unrelated to this PR. Created a followup issue here: #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for HelmRelease objects:
Related protobuf library change: larrymyers/protoc-gen-twirp_typescript@c6a1347