Skip to content

max-height option #5

@rmeissn

Description

@rmeissn

Thank you @jerryshew for this nice and useful library!

A nice addition would be a max-height option (instead of always sizing the image to the maximum width of the container), in order to limit portrait (e.g. 9:16) pictures from being rendered too huge. The implementation could even provide options for setting this as a pixel size or relative to the window/container size, in order to fit the picture to the screen.

Or is there a workaround that I've missed? The only way I can think of is to limit the container width separately for different pictures by reading picture width and height and to add a width limiting grid in case it's a portrait picture.

I noticed that @Pajn implemented the feature as a fork of your project: https://github.com/Pajn/react-image-cropper/commits/master
@Pajn I haven't tested your code yet, but would you be able to issue a PR back to this project, in case your implementation works fine?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions