-
Notifications
You must be signed in to change notification settings - Fork 0
feat: M13 VESSEL — Content-on-Node #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ab1d882
feat(content): add content store core — writeContent, readContent, me…
flyingrobots cf04d3f
feat(cli): add content set|show|meta|delete commands (#273)
flyingrobots bca977e
docs(contracts): add JSON schemas for content CLI output (#274)
flyingrobots 1063d25
test(content): add 27 tests for content store, CLI, and schema contra…
flyingrobots 18da617
chore: bump to v3.3.0, update CHANGELOG for M13 VESSEL (#271)
flyingrobots e8fd499
fix: address code review feedback on M13 VESSEL (#276)
flyingrobots 6619d7f
fix: address remaining CodeRabbit review feedback (#276)
flyingrobots 531e594
docs: add M13 VESSEL review items to backlog (#276)
flyingrobots 49999a9
fix: address 6 self-review issues on M13 VESSEL (#276)
flyingrobots 768a379
fix: address CodeRabbit review round 3-4 feedback (#276)
flyingrobots 4f26436
fix: address CodeRabbit review round 5 nits (#276)
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/neuroglyph/git-mind/docs/contracts/cli/content-delete.schema.json", | ||
| "title": "git-mind content delete --json", | ||
| "description": "Content deletion result from `git mind content delete --json`", | ||
| "type": "object", | ||
| "required": ["schemaVersion", "command", "nodeId", "removed", "previousSha"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "schemaVersion": { "type": "integer", "const": 1 }, | ||
| "command": { "type": "string", "const": "content-delete" }, | ||
| "nodeId": { "type": "string", "minLength": 1 }, | ||
| "removed": { "type": "boolean" }, | ||
| "previousSha": { "type": ["string", "null"], "pattern": "^[0-9a-f]{40,64}$" } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/neuroglyph/git-mind/docs/contracts/cli/content-meta.schema.json", | ||
| "title": "git-mind content meta --json", | ||
| "description": "Content metadata result from `git mind content meta --json`", | ||
| "type": "object", | ||
| "required": ["schemaVersion", "command", "nodeId", "hasContent"], | ||
| "additionalProperties": false, | ||
| "if": { | ||
| "properties": { "hasContent": { "const": true } }, | ||
| "required": ["hasContent"] | ||
| }, | ||
| "then": { | ||
| "required": ["sha", "mime", "size"], | ||
| "properties": { | ||
| "sha": { "type": "string", "pattern": "^[0-9a-f]{40,64}$" }, | ||
| "mime": { "type": "string", "minLength": 1 }, | ||
| "size": { "type": "integer", "minimum": 0 } | ||
| } | ||
flyingrobots marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "else": { | ||
| "properties": { | ||
| "sha": false, | ||
| "mime": false, | ||
| "size": false | ||
| } | ||
| }, | ||
| "properties": { | ||
| "schemaVersion": { "type": "integer", "const": 1 }, | ||
| "command": { "type": "string", "const": "content-meta" }, | ||
| "nodeId": { "type": "string", "minLength": 1 }, | ||
| "hasContent": { "type": "boolean" }, | ||
| "sha": { "type": "string", "pattern": "^[0-9a-f]{40,64}$" }, | ||
| "mime": { "type": "string", "minLength": 1 }, | ||
| "size": { "type": "integer", "minimum": 0 } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/neuroglyph/git-mind/docs/contracts/cli/content-set.schema.json", | ||
| "title": "git-mind content set --json", | ||
| "description": "Content attachment result from `git mind content set --json`", | ||
| "type": "object", | ||
| "required": ["schemaVersion", "command", "nodeId", "sha", "mime", "size"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "schemaVersion": { "type": "integer", "const": 1 }, | ||
| "command": { "type": "string", "const": "content-set" }, | ||
| "nodeId": { "type": "string", "minLength": 1 }, | ||
| "sha": { "type": "string", "pattern": "^[0-9a-f]{40,64}$" }, | ||
| "mime": { "type": "string", "minLength": 1 }, | ||
| "size": { "type": "integer", "minimum": 0 } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://github.com/neuroglyph/git-mind/docs/contracts/cli/content-show.schema.json", | ||
| "title": "git-mind content show --json", | ||
| "description": "Content display result from `git mind content show --json`", | ||
| "type": "object", | ||
| "required": ["schemaVersion", "command", "nodeId", "content", "sha", "mime", "size"], | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "schemaVersion": { "type": "integer", "const": 1 }, | ||
| "command": { "type": "string", "const": "content-show" }, | ||
| "nodeId": { "type": "string", "minLength": 1 }, | ||
| "content": { "type": "string" }, | ||
| "sha": { "type": "string", "pattern": "^[0-9a-f]{40,64}$" }, | ||
| "mime": { "type": "string", "minLength": 1 }, | ||
| "size": { "type": "integer", "minimum": 0 } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.