Skip to content

Conversation

@machichima
Copy link
Member

@machichima machichima commented Dec 31, 2025

Tracking issue

Closes #6814

Why are the changes needed?

Flyte recently released v2.0.0, however, flytectl is only for flyte v1. We should prevent it getting v2 image when building sandbox with flytectl demo start

What changes were proposed in this pull request?

Skip release for flyte version >= v2.x.x

How was this patch tested?

build flytectl and run locally

image

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: machichima <nary12321@gmail.com>
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.93%. Comparing base (fba30ad) to head (0c62638).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flytectl/pkg/github/githubutil.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6834      +/-   ##
==========================================
- Coverage   56.94%   56.93%   -0.01%     
==========================================
  Files         929      929              
  Lines       58139    58144       +5     
==========================================
+ Hits        33105    33107       +2     
- Misses      21993    21995       +2     
- Partials     3041     3042       +1     
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.14% <ø> (ø)
unittests-flytecopilot 43.06% <ø> (ø)
unittests-flytectl 64.00% <40.00%> (-0.03%) ⬇️
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.13% <ø> (ø)
unittests-flytepropeller 53.54% <ø> (ø)
unittests-flytestdlib 63.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@machichima machichima merged commit 85a8f2d into flyteorg:master Jan 1, 2026
51 of 52 checks passed
@machichima machichima mentioned this pull request Jan 1, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Sandbox cluster creation fails

4 participants