Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

[wip] Add size definitions to all model definitions #498

Draft
wild-endeavor wants to merge 41 commits into
base: master
Choose a base branch
from
Draft

[wip] Add size definitions to all model definitions #498

wild-endeavor wants to merge 41 commits into from

Conversation

@wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Dec 3, 2022

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

wild-endeavor and others added 22 commits December 2, 2022 18:39
@wild-endeavor
move things to stdlib
58ebbdf 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
check mysql first since postgres has a default
49a2ec2 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
lowered the column sizes enough to get the node execution event table to
66d556a 
pass migration.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@eapolinario
merge master
2140721 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
WIP - mysql support
a160b2e 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@wild-endeavor
merge master
8aea307 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
add new migrations
1fe4dd2 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
undo all the size deletions
a68cc1c 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@eapolinario
Revert "undo all the size deletions"
e6dbda9 
This reverts commit a68cc1c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Merge remote-tracking branch 'origin' into mysql
d6639ab 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Add Fixup migrations
b83482a 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Reapply migration changes.
0c9d2b4 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove old cruft
8808346 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove gorm changes from migration_models.go
4a1f80a 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
One more pass in setting size constraints
7a43adb 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Revert "One more pass in setting size constraints"
31f0bff 
This reverts commit 7a43adb.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Revert "Remove gorm changes from migration_models.go"
b089e27 
This reverts commit 4a1f80a.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Revert "Remove old cruft"
39ee118 
This reverts commit 8808346.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Revert "Reapply migration changes."
c0c25a0 
This reverts commit 0c9d2b4.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove size statements from models
72b2a85 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Bring back commented code and minor size changes
59d7b36 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Special-case mysql in the case of the task_executions table.
8901ea2 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario changed the title [wip] Move db logic to stdlib [wip] Add size definitions to all model definitions Mar 30, 2023
@eapolinario
Remove size statements from migration_models.go file
9029ec1 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Drop remaining size statements from migration_models.go
93864e6 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove unnecessary gorm statements from base_model.go
4daf1fe 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Drop unnecessary changes.
7252d4b 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Remove unnecessary changes
180715c 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Bring alterTableColumnType back
37827b8 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Move comment to top of fixup migrations
fe80833 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
eapolinario and others added 12 commits March 29, 2023 18:43
@eapolinario
Add separate index to signals table
e31ccd8 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Fix one off errors.
8effaf7 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@wild-endeavor
not null couple columns
6e34716 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
partial treatment of stuff
bcc2b9d 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
add manual indices for resources and task executions
5ccb295 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@eapolinario
Set prefix length in primary_alt index on task_executions table
6cae700 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Separate creation of primary_alt indexes into their own migrations.
e7361cc 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@wild-endeavor
use latest stdlib branch
ef4f5e7 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
propeller to 1.1.83
29c702c 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor
==
e8a0349 
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@eapolinario
Add statements to change the type of primary keys in the case of post…
ce1773a 
…gres.

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Merge master
2cb96ab 
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@katrogan katrogan Awaiting requested review from katrogan katrogan will be requested when the pull request is marked ready for review katrogan is a code owner

@EngHabu EngHabu Awaiting requested review from EngHabu EngHabu will be requested when the pull request is marked ready for review EngHabu is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 will be requested when the pull request is marked ready for review kumare3 is a code owner

@pmahindrakar-oss pmahindrakar-oss Awaiting requested review from pmahindrakar-oss pmahindrakar-oss will be requested when the pull request is marked ready for review pmahindrakar-oss is a code owner

@hamersaw hamersaw Awaiting requested review from hamersaw hamersaw will be requested when the pull request is marked ready for review hamersaw is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario will be requested when the pull request is marked ready for review eapolinario is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wild-endeavor @eapolinario