This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Use configured domain on expired cookies #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
iaroslav-ciupin
requested review from
EngHabu,
eapolinario,
hamersaw,
katrogan,
kumare3,
pmahindrakar-oss and
wild-endeavor
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 58.74% 60.43% +1.68%
==========================================
Files 171 171
Lines 16472 13442 -3030
==========================================
- Hits 9676 8123 -1553
+ Misses 5944 4471 -1473
+ Partials 852 848 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
katrogan
reviewed
Aug 31, 2023
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
katrogan
approved these changes
Sep 1, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* use configured domain on expired cookies Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai> * unit tests coverage Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai> --------- Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When expiring cookie during logout, we must use same configured domain as when setting those cookies.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/