This repository was archived by the owner on Oct 9, 2023. It is now read-only.
#patch Update FromWorkflowModel API #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squiishyy
requested review from
EngHabu,
eapolinario,
hamersaw,
katrogan,
kumare3,
pmahindrakar-oss and
wild-endeavor
as code owners
squiishyy
force-pushed
the
CLOUD-1177-listworkflow-call
branch
from
736bd1e to
ed9e9d3
Compare
katrogan
reviewed
Sep 23, 2023
Contributor
katrogan
left a comment
katrogan
left a comment
There was a problem hiding this comment.
looks great! let's make sure to test end to end before merging
katrogan
reviewed
Sep 25, 2023
Contributor
katrogan
left a comment
katrogan
left a comment
There was a problem hiding this comment.
looks good! you may need to follow the instructions for DCO sign-off
squiishyy
force-pushed
the
CLOUD-1177-listworkflow-call
branch
from
baa0285 to
856eeaf
Compare
squiishyy
changed the title
…object. updated tests Signed-off-by: Guest Account <guestaccount@Guests-MacBook-Pro.local> Signed-off-by: Joe Eschen <joe@union.ai>
…f checks Signed-off-by: Joe Eschen <joe@union.ai>
Signed-off-by: Joe Eschen <joe@union.ai>
Signed-off-by: Joe Eschen <joe@union.ai>
squiishyy
force-pushed
the
CLOUD-1177-listworkflow-call
branch
from
ad92ecd to
f1d9603
Compare
Signed-off-by: Joe Eschen <joe@union.ai>
Signed-off-by: Joe Eschen <joe@union.ai>
Signed-off-by: Joe Eschen <joe@union.ai>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 59.01% 60.59% +1.57%
==========================================
Files 171 171
Lines 16468 13454 -3014
==========================================
- Hits 9719 8152 -1567
+ Misses 5899 4451 -1448
- Partials 850 851 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
katrogan
approved these changes
Sep 26, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update FromWorkflowModel to include TypedInterface in response object
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://unionai.atlassian.net/browse/CLOUD-1177
Follow-up issue
NA