This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Add batched reasons to TaskExecutionEvent #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 75.92% 75.92%
=======================================
Files 18 18
Lines 1458 1458
=======================================
Hits 1107 1107
Misses 294 294
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Sep 21, 2023
katrogan
reviewed
Sep 26, 2023
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
…k8s-events Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
katrogan
approved these changes
Sep 27, 2023
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
hamersaw
approved these changes
Sep 27, 2023
katrogan
approved these changes
Sep 27, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Add batched reasons to TaskExecutionEvent Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Change event name Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Rename Reason to EventReason Signed-off-by: Andrew Dye <andrewwdye@gmail.com> --------- Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Deprecate
TaskExecutionEvent.reasonin favor ofTaskExecutionEvent.reasonsto send batched events from flytepropeller, each with their own timestamp.Type
Are all requirements met?
Complete description
This change makes it possible to send kubernetes events as described in flyteorg/flyte#3825 without overloading propeller or admin with a large increase in TaskExecutionEvents. It deprecates
TaskExecutionEvent.reasonin favor of a repeatedTaskExecutionEvent.reasons, which includes separate timestamps for each event. This allows for sending multiple reasons as part of the same event.Tracking Issue
flyteorg/flyte#3825
Follow-up issue
N/A