Skip to content

Conversation

@narape
Copy link
Contributor

@narape narape commented Feb 1, 2023

TL;DR

Add description annotation for scala case classes

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • A new scala annotation was created.
  • The SdkScalaType search for it when reading the case classes fields
  • When building the variable map it will set up the description or empty String if nothing was found

Tracking Issue

fixes flyteorg/flyte#3303

Follow-up issue

NA

Signed-off-by: Nelson Arapé <nelson@spotify.com>
Signed-off-by: Nelson Arapé <nelson@spotify.com>
Signed-off-by: Nelson Arapé <nelson@spotify.com>
@narape narape merged commit 542ba84 into master Feb 1, 2023
@narape narape deleted the add-description-scala branch February 1, 2023 14:42
Copy link
Collaborator

@andresgomezfrr andresgomezfrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late, but ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flytekit-java] Remove duplication of workflow inputs and outputs

4 participants