Make plugin task first-class citizen #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
andresgomezfrr
approved these changes
Dec 11, 2023
honnix
added a commit
that referenced
this pull request
Dec 11, 2023
This reverts commit 78cd22d. Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
added a commit
that referenced
this pull request
Dec 11, 2023
honnix
added a commit
that referenced
this pull request
Dec 11, 2023
8 tasks
honnix
added a commit
that referenced
this pull request
Dec 11, 2023
andresgomezfrr
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Revert "Revert "Make plugin task first-class citizen (#268)" (#271)" This reverts commit 3d9ab4e. Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com> * Drop isSyncPlugin for now Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com> * Skip staging and merging custom where applicable Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com> * Skip container Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com> * More description of SdkPluginTask Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com> --------- Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Create a dedicated Plugin Task instead of abusing Runnable Task.
Type
Are all requirements met?
Complete description
runreturningnullNote that it is still supported to use Runnable Task to implement tasks that are handled by backend plugin, for backward compatibility.
Tracking Issue
flyteorg/flyte#3936
Follow-up issue
NA