Skip to content

Conversation

@wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 21, 2023

TL;DR

This is an errorneous error line. This comes up multiple times when running the merge sort example, which does not call a task within a task.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

2023-08-21 16:49:11,422980 ERROR    {"asctime": "2023-08-21 16:49:11,422", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}
2023-08-21 16:49:11,427233 ERROR    {"asctime": "2023-08-21 16:49:11,427", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}
2023-08-21 16:49:11,428440 ERROR    {"asctime": "2023-08-21 16:49:11,428", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}
2023-08-21 16:49:11,429852 ERROR    {"asctime": "2023-08-21 16:49:11,429", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}
2023-08-21 16:49:11,431182 ERROR    {"asctime": "2023-08-21 16:49:11,431", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}
2023-08-21 16:49:11,432417 ERROR    {"asctime": "2023-08-21 16:49:11,432", "name": "flytekit", "levelname": "ERROR", "message": "You are not supposed to nest   promise.py:1006
                                    @Task/@Workflow inside a @Task!"}

Tracking Issue

NA

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@eapolinario
Copy link
Collaborator

This feature is useful as we had multiple people being bitten by this in the past.

This problem you're seeing with mergesort is very likely caused by @dynamic, so can we double-check that this is the case and if so handle that case?

@eapolinario
Copy link
Collaborator

Fixed by #1812.

@eapolinario eapolinario closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants