feat(resources): support serialization of Resources dataclasses #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support serialization of Resources and ResourceSpec - allow passing these as configuration to workflows or between tasks Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
cameronraysmith
force-pushed
the
serialize-resources
branch
from
e9190c6 to
07f8788
Compare
cameronraysmith
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2250 +/- ##
==========================================
- Coverage 86.01% 83.52% -2.49%
==========================================
Files 322 296 -26
Lines 24376 23205 -1171
Branches 3689 3477 -212
==========================================
- Hits 20966 19383 -1583
- Misses 2754 3201 +447
+ Partials 656 621 -35 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Mar 10, 2024
|
Congrats on merging your first pull request! 🎉 |
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Mar 16, 2024
…eorg#2250) * feat(resources): inherit from from DataClassJSONMixin - support serialization of Resources and ResourceSpec - allow passing these as configuration to workflows or between tasks Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com> * test(resources): add tests to (de)serialize Resources instances Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* feat(resources): inherit from from DataClassJSONMixin - support serialization of Resources and ResourceSpec - allow passing these as configuration to workflows or between tasks Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com> * test(resources): add tests to (de)serialize Resources instances Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If one would like to pass Resources instances as configuration to workflows, they need to be serializable.
What changes were proposed in this pull request?
Following #1735, declare Resources and ResourceSpec to inherit from DataClassJSONMixin
How was this patch tested?
Check all the applicable boxes
Related PRs