Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

@Future-Outlier
Copy link
Member

Reverts #398

…fig twice. (flyteorg#398)"

This reverts commit 2598c96.

Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier Future-Outlier force-pushed the revert-398-add-supportedTaskTypes-for-agent-service-by-default-for-task-types branch from 4dc7f57 to 1fd95a1 Compare October 3, 2023 02:57
@pingsutw pingsutw requested a review from honnix October 3, 2023 03:39
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (445fc58) 62.86% compared to head (3f5a76c) 64.19%.

❗ Current head 3f5a76c differs from pull request most recent head 1fd95a1. Consider uploading reports for the commit 1fd95a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   62.86%   64.19%   +1.32%     
==========================================
  Files         156      156              
  Lines       13201    10704    -2497     
==========================================
- Hits         8299     6871    -1428     
+ Misses       4271     3202    -1069     
  Partials      631      631              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
go/tasks/plugins/webapi/agent/config.go 100.00% <ø> (ø)
go/tasks/plugins/webapi/agent/plugin.go 68.53% <50.00%> (+2.48%) ⬆️

... and 136 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit e4ece18 into flyteorg:master Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants