Skip to content

Consolidating relative to upstream#69

Merged
jvoigtlaender merged 10 commits intofmiduefrom
google-master
Apr 20, 2026
Merged

Consolidating relative to upstream#69
jvoigtlaender merged 10 commits intofmiduefrom
google-master

Conversation

@jvoigtlaender
Copy link
Copy Markdown
Member

That's how "catching up" would look.

Copilot AI review requested due to automatic review settings April 16, 2026 15:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs the repository with upstream changes, updating build/install dependencies and CI configuration to match newer environments.

Changes:

  • Update Ubuntu apt dependency from libncurses5{,-dev} to libncurses-dev and add Node.js install guidance in install.sh.
  • Add an explicit version bound for http-conduit in codeworld-server.cabal.
  • Move GitHub Actions CI runner from Ubuntu 20.04 to 24.04.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
install.sh Updates system package dependencies and expands Node.js installation notes.
codeworld-server/codeworld-server.cabal Constrains http-conduit to a specific compatible version range.
.github/workflows/ci.yml Updates the Linux runner image to Ubuntu 24.04.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread install.sh Outdated
Comment thread install.sh Outdated
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@jvoigtlaender
Copy link
Copy Markdown
Member Author

Are we using .github/workflows/ci.yml and/or install.sh at all in this repo/on our server? Should these files simply be dropped here?

@patritzenfeld, @nimec01

@patritzenfeld
Copy link
Copy Markdown
Member

patritzenfeld commented Apr 17, 2026

The server uses build-docker.sh which does not call install.sh at all. But I think the contents of that file are somewhat copied from install.sh and some of the other scripts in the repo. I don't know if using these scripts manually is better for local development, so maybe @nimec01 can answer this.

As for the CI, it wasn't running in the repo before this pull request opened. But I think a basic "everything compiles" check is reasonable. I don't think fixing the workflow will take much time.

@nimec01
Copy link
Copy Markdown
Collaborator

nimec01 commented Apr 17, 2026

The server uses build-docker.sh which does not call install.sh at all. But I think the contents of that file are somewhat copied from install.sh and some of the other scripts in the repo. I don't know if using these scripts manually is better for local development, so maybe @nimec01 can answer this.

I don't use any of the scripts locally. I basically develop inside a Docker container that uses the latest build. The content of install.sh was only used to derive a working Dockerfile and build-docker.sh script. We also don't use the test.sh and build.sh script.

As for the CI, it wasn't running in the repo before this pull request opened. But I think a basic "everything compiles" check is reasonable. I don't think fixing the workflow will take much time.

Just keep in mind that the Docker build already takes some time. We would need proper caching to make sure the workflow won't time out.

jvoigtlaender and others added 2 commits April 17, 2026 16:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jvoigtlaender jvoigtlaender changed the title New commits upstream Consolidating relative to upstream Apr 17, 2026
Comment thread codeworld-server/codeworld-server.cabal
@jvoigtlaender jvoigtlaender merged commit 72e6971 into fmidue Apr 20, 2026
0 of 2 checks passed
@jvoigtlaender jvoigtlaender deleted the google-master branch April 20, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants