Consolidating relative to upstream#69
Conversation
There was a problem hiding this comment.
Pull request overview
Syncs the repository with upstream changes, updating build/install dependencies and CI configuration to match newer environments.
Changes:
- Update Ubuntu apt dependency from
libncurses5{,-dev}tolibncurses-devand add Node.js install guidance ininstall.sh. - Add an explicit version bound for
http-conduitincodeworld-server.cabal. - Move GitHub Actions CI runner from Ubuntu 20.04 to 24.04.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
install.sh |
Updates system package dependencies and expands Node.js installation notes. |
codeworld-server/codeworld-server.cabal |
Constrains http-conduit to a specific compatible version range. |
.github/workflows/ci.yml |
Updates the Linux runner image to Ubuntu 24.04. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Are we using |
|
The server uses As for the CI, it wasn't running in the repo before this pull request opened. But I think a basic "everything compiles" check is reasonable. I don't think fixing the workflow will take much time. |
I don't use any of the scripts locally. I basically develop inside a Docker container that uses the latest build. The content of
Just keep in mind that the Docker build already takes some time. We would need proper caching to make sure the workflow won't time out. |
ca883bf to
72e6971
Compare
That's how "catching up" would look.