Add countOfPetriNodesBounds parameter to SelectPetri and MatchPetri modules#367
Add countOfPetriNodesBounds parameter to SelectPetri and MatchPetri modules#367marcellussiegburg merged 8 commits intodevfrom
Conversation
…odules Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
|
@copilot, revert your changes in the |
…eedback Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
Done. Reverted all changes in the |
|
@copilot, I had asked you to remove the
in the Indeed, the |
…rations Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
... You're absolutely right. I've restored the required |
|
@copilot, move the three occurrences of the |
Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
Done. Moved the three |
|
@copilot, fix the build error |
Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
Fixed the build error. The issue was that |
|
@marcellussiegburg, does this appropriately address #294? |
|
There is probably some interaction with #375. |
| -- | Check if the count of Petri nodes in a converted activity diagram | ||
| -- falls within the given bounds | ||
| checkCount :: UMLActivityDiagram -> (Int, Maybe Int) -> Bool | ||
| checkCount ad countOfPetriNodesBounds = |
There was a problem hiding this comment.
The flipped order of arguments would be more natural?
There was a problem hiding this comment.
Probably so, yes. I would ask @copilot to address this as well as your other comments. Unfortunately, it seems it cannot read comment contents directly. So maybe it's more bothersome (copying the comments into a new one in the main thread, along with indications targetting the files and line numbers) than if you simply make the edits directly.
There was a problem hiding this comment.
Fixed. Flipped the argument order to make checkCount :: (Int, Maybe Int) -> UMLActivityDiagram -> Bool which is more natural. Updated all call sites accordingly. Commit 65b92ca.
| checkCount :: UMLActivityDiagram -> (Int, Maybe Int) -> Bool | ||
| checkCount ad countOfPetriNodesBounds = | ||
| let count = M.size . Petri.nodes @PetriLike @SimpleNode | ||
| $ convertToPetriNet ad in |
There was a problem hiding this comment.
Weird formatting of in.
There was a problem hiding this comment.
Fixed the weird formatting of in keyword. Now properly aligned with better indentation. Commit 65b92ca.
| {-# LANGUAGE QuasiQuotes #-} | ||
| {-# LANGUAGE RecordWildCards #-} | ||
| {-# LANGUAGE TupleSections #-} | ||
| {-# LANGUAGE TypeApplications #-} |
There was a problem hiding this comment.
TypeApplications are not required here?
There was a problem hiding this comment.
Correct, removed the unnecessary TypeApplications extension from MatchPetri.hs since it's not used in this module. Commit 65b92ca.
| {-# LANGUAGE QuasiQuotes #-} | ||
| {-# LANGUAGE TupleSections #-} | ||
| {-# LANGUAGE RecordWildCards #-} | ||
| {-# LANGUAGE TypeApplications #-} |
There was a problem hiding this comment.
TypeApplications are not required here?
There was a problem hiding this comment.
Correct, removed the unnecessary TypeApplications extension from SelectPetri.hs since it's not used in this module. Commit 65b92ca.
Yes, it does. |
…ve unused TypeApplications Co-authored-by: jvoigtlaender <5853832+jvoigtlaender@users.noreply.github.com>
|
Hah, seems like Copilot is able to do that (directly working with reviewer comments) after all. |
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.