Ensure that CHECK's expressions are wrapped in parentheses#667
Merged
Conversation
Owner
|
@Weyzu thank you. Let's wait builds and if everything is ok with them I shall merge this PR |
Owner
|
@Weyzu merged. Thank you. IDK why not all checks processed but it looks like ok to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example table creation:
Creates a CHECK statement which expression is not wrapped properly in parentheses, i.e.
Proper CHECK syntax in this example would be
CHECK ("main" IN ( 0, 1 )).The following pull request makes a small change to fix this. As I'm not a regular here, the required change may be more sophisticated than what I'm proposing. Nevertheless, the fix should solve the issue for the mentioned case scenario.