fix(line-wrapper): instead of gradually decrementing the word size to fit the available space, reduce it by the range of available space and adjust it #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fit the available space, reduce it by the range of available space and adjust it
fix(line-wrapper): instead of gradually decrementing the word size to fit the available space, reduce it by the range of available space and adjust it
|
Any chance we could get this approved and merged? Thanks. |
Collaborator
|
Thanks. This is fixed by #796 (it uses the same logic) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradually decrementing the word size to fit the available space is causing a JavaScript heap out of memory error when the word size is sufficiently large (1000 chars). This situation might not happen for regular english words but it might happen for large URLs.
This implementation resolves this issue.