Skip to content

Fix linewrapper ellipsis inifinite loop #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alafr merged 1 commit into from
Jun 29, 2018
Merged

Fix linewrapper ellipsis inifinite loop #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/line_wrapper.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,16 @@ class LineWrapper extends EventEmitter
textWidth = @wordWidth buffer + @ellipsis

# remove characters from the buffer until the ellipsis fits
while textWidth > @lineWidth
# to avoid inifinite loop need to stop while-loop if buffer is empty string
while buffer and textWidth > @lineWidth
buffer = buffer.slice(0, -1).replace(/\s+$/, '')
textWidth = @wordWidth buffer + @ellipsis

buffer = buffer + @ellipsis

# need to add ellipsis only if there is enough space for it
if textWidth <= @lineWidth
buffer = buffer + @ellipsis

textWidth = @wordWidth buffer

if bk.required
if w > @spaceLeft
emitLine()
Expand Down