Implement integration tests #806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice ! |
…s a pdf with the difference if snapshot does not matches
Member
Author
|
This is basically done. It tests the pdf generated by scripts based on pdfkit demos and from pdfmake. It uses jest snapshots and also creates reference pdf file, and eventually the changed one, in __pdfs__ directory. It would still need to create unit tests (per classes) but its enough to convert to ES6 with good confidence |
Member
Author
|
Superseded by #859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement tests for rendered pages. Uses jest framework.
Initially added simple tests to discuss the code structure, so more can be added later.
Also added a test with the output generated by a pdfmake basics example (trapped pdfkit calls and exported them). The same process can be done with the remaining examples or other pdfkit based libraries
Another idea (not implemented yet) is to store a reference pdf file for each test and create a new one when test does not match. Useful for visualizing the difference