Change cmake minimum version to 3.5

[szekipepe]

Change cmake minimum version to 3.5 to work after 3.27 versions of cmake.

log with cmake 3.27.6:
Compatibility with CMake < 3.5 will be removed from a future version of CMake.

[szekipepe]

I just thinking... maybe we can use cmake minimum version as this:

cmake_minimum_required(VERSION 3.1...3.5)

Would that be better?

[neithernut]

Disclaimer: not a maintainer.

Just had a look out of curiosity, and CMake 3.5 was apparently released in March 2016, more than seven years ago¹. I doubt anyone building new(er) software would use an older version, and maintainers of legacy code still using such an old version of CMake are likely ok with not upgrading some dependencies. I think it's ok to just bump the CMake version like you did.

Footnotes

1. I"m honestly pleasantly surprised they still have the old release pages up and usable on their current website. ↩

[foonathan]

Yeah, I think requiring 3.5 is fine.