Session expired or invalid

[chripede]

When using this to bulk send data (one item at a time) I am hit with

Exception: [{'message': 'Session expired or invalid', 'errorCode': 'INVALID_SESSION_ID'}]

regularly.

For each request I do with SalesforceClient as client so there is no way it will actually expire, unless it does within a second?

[caffalaughrey]

The extent to which the client currently manages the session is:

• assign the access_token from a successful login request
• reuse it for all subsequent requests

To handle your scenario where session timeout is a factor and a fresh session id is needed, we would need to support the refresh token flow. I'd be open to it

[ericbn]

I had "INVALID_SESSION_ID: Session expired or invalid" errors before, and found out the root cause was having concurrent sessions and one of them calling logout() while the other sessions were still in use, and this invalidated them. Also, if you're using Client as a context manager, logout() will be called when the context exists.

See https://developer.salesforce.com/forums/?id=906F00000005LQoIAM

Never had a single INVALID_SESSION_ID again after I stopped calling logout() or using Client as a context manager.

Given this, I'd say that logout() is evil and should never be called. Automatically refreshing the token would be hiding the issue, so I'm not if favor of adding that feature.

_{* By "using Client as a context manager" I mean:}

with sfdc.client(**client_args) as client:
    ...

[ericbn]

After having more experience with this, I'd say:

1. logout() is evil and should never be called. I'm in favor of even removing it from future versions of this package.
2. Automatically refreshing the token is necessary. Tokens eventually expire, and if this package is being used in a long running process, it's a necessary feature that the token will be automatically refreshed.

[caffalaughrey]

@ericbn , FYI created #76 and #77 for these.