Skip to content

FIO-9942: Fix issue with disabling evaluations#239

Merged
brendanbond merged 1 commit intomasterfrom
FIO-9942-noeval-option-fix
Apr 9, 2025
Merged

FIO-9942: Fix issue with disabling evaluations#239
brendanbond merged 1 commit intomasterfrom
FIO-9942-noeval-option-fix

Conversation

@Maria-Golomb
Copy link
Copy Markdown
Contributor

@Maria-Golomb Maria-Golomb commented Apr 9, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9942

Description

Refactored the static noeval flag across BaseEvaluator, Evaluator, and JSONLogicEvaluator classes to ensure consistency. Introduced a getter and setter for noeval in BaseEvaluator to centralize its value and make it shared across all evaluator layers.
Previously, each evaluator class had its own separate static noeval property, which caused inconsistencies when toggling evaluation behavior.

Breaking Changes / Backwards Compatibility

Dependencies

How has this PR been tested?

manually
autotests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@Maria-Golomb Maria-Golomb force-pushed the FIO-9942-noeval-option-fix branch from 8904144 to eac43c1 Compare April 9, 2025 20:42
@brendanbond brendanbond merged commit 2093e0d into master Apr 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants