Conversation
Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found when checking 2 changed file(s)! 🎉 |
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-03-19 15:23:57 UTC The staging site shows the combined state of all compatible open PRs. |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
@copilot this does not work - I cannot navigate to results as the box is far too big. Rethink the layout - maybe have the search as a collapsible section on the left? |
|
@LukasWallrich I've opened a new pull request, #650, to work on those changes. Once the pull request is ready, I'll request review from you. |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
* Initial plan * Redesign cluster search as collapsible left sidebar Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com> * Fix code review feedback: use alert-info for no results and prevent layout shift Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
1 similar comment
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
@copilot the closing button is behind the navbar, make sure it is visible. Also, when scrolling to a result, that result appears at the bottom of the window. Scroll so that it is at the top |
|
@LukasWallrich I've opened a new pull request, #654, to work on those changes. Once the pull request is ready, I'll request review from you. |
📝 Spell Check ResultsFound 5 potential spelling issue(s) in this PR: 📄
|
| Line | Issue |
|---|---|
| 16 | Wit ==> With |
📄 content/glossary/english/plan_s.md
| Line | Issue |
|---|---|
| 4 | commited ==> committed |
📄 content/glossary/english/pro.md
| Line | Issue |
|---|---|
| 4 | publically ==> publicly |
📄 content/glossary/english/research_protocol.md
| Line | Issue |
|---|---|
| 4 | publically ==> publicly |
📄 content/glossary/english/type_i_error.md
| Line | Issue |
|---|---|
| 4 | occured ==> occurred |
ℹ️ How to address these issues:
- Fix the typo: If it's a genuine typo, please correct it.
- Add to whitelist: If it's a valid word (e.g., a name, technical term), add it to
.codespell-ignore.txt - False positive: If this is a false positive, please report it in the PR comments.
🤖 This check was performed by codespell
* Initial plan * Fix search panel visibility and scroll behavior Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com> Co-authored-by: Lukas Wallrich <lukas.wallrich@gmail.com>
- Auto-hide panel when clicking search result - Position panel below navbar to avoid hiding logo - Reduce panel width to 70% on mobile devices - Show only search icon on mobile toggle button
|
@LukasWallrich i made a commit with the below improvements
|
|
Make sure it scrolls to the reference hit, not the cluster title (or at least moves the cluster title to the top of the page) Make cluster titles searchable (e.g. QRP should return hits) |
- Make cluster titles and tab labels searchable (e.g., searching "QRP" now finds the "QRPs" tab) - Search section description text outside of tabs - Scroll to the first highlighted match within a tab pane instead of the cluster section top - Handle section-level results (description/title matches) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Show one result per matching paragraph/reference instead of per tab
- Filter out nested blocks (p inside li) to avoid duplicate results
- Fix cluster name: use h1 (actual title) not h3 ("Description")
- Live search as user types with 300ms debounce
- Make tab labels searchable (e.g. "QRP" finds "QRPs" tab)
- Scroll to the specific matched element, not the section top
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@richarddushime This is ready for review. Changes since last feedback:
|
|
try to search |
This is the start of an implementation of a search function. Currently, the results display is not great and the box does not close when trying to navigate it