Skip to content

adapt settings to golangci-lint 1.59.1 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldemailly merged 2 commits into from
Jul 10, 2024
Merged

adapt settings to golangci-lint 1.59.1 #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f898098
adapt settings to golangci-lint 1.59.1
ldemailly Jul 10, 2024
074ee16
review comment
ldemailly Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ linters-settings:
max-func-lines: 30
nolintlint:
require-specific: true
# require-explanation: true # add this when we fix it/review nolints in fortio/fortio
whitespace:
multi-if: false # Enforces newlines (or comments) after every multi-line if statement
multi-func: false # Enforces newlines (or comments) after every multi-line function signature
Expand All @@ -73,6 +74,9 @@ linters:
- musttag
Comment thread
ldemailly marked this conversation as resolved.
# Deprecated ones:
- gomnd
- execinquery
# Redundant ones:
- gofmt # we use gofumpt
# Weird/bad ones:
- wsl
Comment thread
ccoVeille marked this conversation as resolved.
- nlreturn
Comment thread
ldemailly marked this conversation as resolved.
Expand All @@ -81,7 +85,6 @@ linters:
- mnd
Comment thread
ldemailly marked this conversation as resolved.
- testpackage
- wrapcheck
Comment thread
ldemailly marked this conversation as resolved.
- exhaustivestruct
- tagliatelle
- nonamedreturns
- varnamelen
Expand All @@ -90,7 +93,6 @@ linters:
- paralleltest
- thelper
Comment thread
ldemailly marked this conversation as resolved.
- forbidigo
- ifshort
- wastedassign
- cyclop
- forcetypeassert
Expand Down