Notification settings persistence

[fortune710]

Creates an initial notification settings record in the database based on OS permission outcome and enforces permission checks when re-enabling push notifications to fulfill DEF-89.

The issue required saving default notification preferences (all true for granted, all false for denied) upon the first permission request. It also mandated that the "Push Notifications" toggle re-check or request OS permission before allowing the user to turn it back on, ensuring consistency between app settings and OS permissions. A refinement was made to prevent overwriting existing user preferences if the settings row already existed when the push notification toggle was re-enabled.

---

Linear Issue: DEF-89

 

Summary by CodeRabbit

• Bug Fixes

  • Fixed push notification permission handling to properly request and track device-level permissions before enabling notifications.

• Improvements

  • Notification settings are now automatically initialized based on device permission status.
  • Added iOS and Android permission verification for push notifications.
  • Push notifications now aligned with user profile context.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
keepsafe	Ready	Preview, Comment	Jan 27, 2026 5:14am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR integrates OS-level push notification permission handling into the existing notification system. When enabling push notifications, the system now checks device support, requests OS permissions, and initializes notification settings based on permission outcomes. The usePushNotifications hook accepts a userId parameter to coordinate permission-based initialization across hooks and services.

Changes

Cohort / File(s)	Summary
Hook Parameter Updates frontend/app/capture/_layout.tsx	Passes profile?.id to usePushNotifications, aligning hook invocation with user context.
Push Notification Hook Enhancement frontend/hooks/use-push-notifications.ts	Adds optional userId parameter; introduces permissionStatus state tracking; adds effect to initialize notification settings from permission when userId is available; fixes listener cleanup logic to correctly target responseListener.current?.remove().
Notification Settings Hook Integration frontend/hooks/use-notification-settings.ts	Adds device/OS permission handling when enabling PUSH_NOTIFICATIONS: verifies device support, checks/requests OS permissions, calls new service initialization method, and persists permission outcomes before updating toggle states.
Push Notification Service Expansion frontend/services/push-notification-service.ts	Adds ALL_NOTIFICATIONS_ON and ALL_NOTIFICATIONS_OFF constant maps; introduces saveNotificationsSettings() alias; adds initializeNotificationSettingsFromPermission(userId, permissionGranted) to create initial settings based on device-level permission status with existence checking and error handling.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant CaptureLayout
    participant usePushNotifications
    participant Device/OS
    participant PushNotificationService
    participant SettingsStorage

    User->>CaptureLayout: Load app
    CaptureLayout->>usePushNotifications: Call with profile?.id
    usePushNotifications->>Device/OS: Request notification permission
    Device/OS-->>usePushNotifications: Permission status (granted/denied)
    usePushNotifications->>usePushNotifications: Update permissionStatus state
    
    alt userId available and permission checked
        usePushNotifications->>PushNotificationService: initializeNotificationSettingsFromPermission(userId, isGranted)
        PushNotificationService->>SettingsStorage: Check existing settings
        
        alt Settings don't exist
            alt Permission granted
                PushNotificationService->>SettingsStorage: Save ALL_NOTIFICATIONS_ON
            else Permission denied
                PushNotificationService->>SettingsStorage: Save ALL_NOTIFICATIONS_OFF
            end
            PushNotificationService-->>usePushNotifications: true (first-time init)
        else Settings exist
            PushNotificationService-->>usePushNotifications: false (already initialized)
        end
    end
    
    usePushNotifications-->>CaptureLayout: Push notifications configured

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• added notification settings to local storage and synced to supabase #6 — Both PRs modify the notification settings and push-notifications flow, touching use-notification-settings.ts and push-notification-service.ts to enhance notification initialization and settings management APIs.

Poem

🐰 A hop towards permissions so fine,
Device checks and OS calls align,
Settings bloom when granted they be,
Push notifications wild and free! 🔔✨

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}