Rectify Missing Dataloader Preparation Call in PaddingFree Plugin Method#63
Merged
fabianlim merged 1 commit intofoundation-model-stack:mainfrom Aug 6, 2024
Conversation
Signed-off-by: 1000960000 user <aaron.chew1@ibm.com>
9d1cb39 to
8a3e8bf
Compare
Contributor
|
Whats the difference between "Padded-Longest" and "Transformers Padded"? If there is no difference please edit the description to make it consistent |
fabianlim
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a missing dataloader preparation call in the PaddingFree Plugin that will cause num optimization steps in distributed experiments to be computed wrongly.
With this fix, the relative performance improvement between
paddedvspadding-freeapproximately matches forORCA Math 20K Subset - 1 Epoch
Transformers
FMS-Acceleration Padding-Free Plugin