Add target="" support for button component#23
Add target="" support for button component#23vincentducorps wants to merge 1 commit intofoundation:masterfrom
Conversation
|
We have no issue adding this, other than added complexity. Is there a reason we need it in an email though? And as far as I can tell, most webmail clients automatically open links in new tabs without there being a need for a specified target. |
|
This is particularly convenient for the web version of the email. :) |
|
Eventually the parser should copy all (non-custom) attributes from the original tag to the new one, for all components. |
|
@vincentducorps I think we'll pull this in, but do you think all buttons should automatically have a target="_blank"? Perhaps we can extend Inky to add that? |
|
Also - Just published the Foundation for Emails 2.1 release blog post and the release went out this morning! We also started a discussion on the future of Inky and what amazing integrations can be made. I'm sure you have some comments, questions, or ideas: http://foundation.zurb.com/forum/posts/39717-architecting-the-future-of-foundation-for-emails |
|
I don't know, it depends on your specifications. Maybe "_blank" by default and the possibility to make it in "_self". |
No description provided.