Added data-attribute no-expander to <columns> to disable the .expander#29
Merged
rafibomb merged 2 commits intofoundation:masterfrom May 18, 2016
Merged
Added data-attribute no-expander to <columns> to disable the .expander#29rafibomb merged 2 commits intofoundation:masterfrom
rafibomb merged 2 commits intofoundation:masterfrom
Conversation
added 2 commits
April 5, 2016 12:00
…r TH being added.
3 new test with no-expander on columns (case only empty Data-attribute no-expander, Data-attribute no-expander = false & Data-attribute no-expander = true)
Member
|
We talked about doing something like this. Like the way you made it an attribute. Can you share a code example use case we can test against to make sure this PR solves it? |
Author
This is the mail we made. (all names of the company cleared.) On windows outlook (live) mail the images went to 50%; With the addition: Then it worked for 100% wide. |
Member
|
Looking to pull this in for the next release. Here's the update: Just published the Foundation for Emails 2.1 release blog post and the release went out this morning! We also started a discussion on the future of Inky and what amazing integrations can be made. I'm sure you have some comments, questions, or ideas: http://foundation.zurb.com/forum/posts/39717-architecting-the-future-of-foundation-for-emails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added data-attribute no-expander to to disable the .expander.
Reason of adding:
To disable adding th.expander on a column when it has 12 size.
It breaks the full width images in the emails in MS outlook & MS live, setting the width of the cell 50%.
With this edit, you can disable the expander, by adding no-expander to
Example:
<columns large="12" small="12" no-expander>One</columns>Results in:
`