fix: trust CA in login keychain instead of system keychain#11
Merged
willisrocks merged 8 commits intomainfrom Mar 10, 2026
Merged
fix: trust CA in login keychain instead of system keychain#11willisrocks merged 8 commits intomainfrom
willisrocks merged 8 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ps, naming rationale Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorder Task 1 to test-first (write failing test, verify compile error, then implement). Add doc comment update for trust_ca_in_system to accurately describe per-platform behavior after the fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add documentation about the macOS Keychain Access password dialog that users will see (matches mkcert behavior). Replace fragile starts_with "/Users/" test assertion with is_absolute() check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The system keychain requires sudo, which always fails since devproxy runs as the current user via socket activation. Switch to the login keychain (no sudo, just a one-time Keychain Access dialog) and update all user-facing messages in init to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix test cleanup to use `remove-trusted-cert` without `-d` flag, matching the user trust store where the cert was added (not admin store) - Revert unrelated formatting changes in init.rs to keep diff surgical Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update docs/spec.md and skills/setup/SKILL.md to reference login keychain instead of system keychain (finding #1) - Use distinct CN "devproxy Test CA" in roundtrip test to avoid colliding with real devproxy CAs in the login keychain (finding #3) - Update e2e test to accept trust success (no longer requires sudo fallback output since login keychain trust succeeds without sudo) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Library/Keychains/System.keychainwith-dflag, requiring sudo) to login keychain (~/Library/Keychains/login.keychain-db, no sudo)login_keychain_path()helper usingdirs::home_dir()for dynamic path resolutioninit.rsto reference login keychain and remove sudo referencesdocs/spec.mdandskills/setup/SKILL.mdto reflect the change#[ignore]functional roundtrip testTest Plan
cargo clippy -- -D warnings: zero warningscargo test: 15 passed, 9 ignoredResidual Issues
trust_ca_in_system(doc comment updated, rename deferred as low-priority)🤖 Generated with Claude Code