Improve Rust Flatbuffers crate#1
Merged
Merged
Conversation
bennetthardwick
approved these changes
Apr 4, 2025
bennetthardwick
left a comment
There was a problem hiding this comment.
I don't know much about flatbuffers but I'm sure this will get covered enough by usage in the message path changes.
james-rms
reviewed
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs and adds support for missing features to the
flatbuffersandflatbuffers_reflectioncrates.get_field_vector()only works for vectors of primitive types google/flatbuffers#8550get_field_*functions infallible as their success is implied by the unsafe preconditionVector::cast()for casting between vector typesget_type_size()Struct::bytes()to get a slice to a byte buffer which starts with the struct value