Skip to content

WIP: Add model responses#1

Merged
KriSun95 merged 15 commits into
foxsi:mainfrom
KriSun95:add-model-responses
Sep 23, 2025
Merged

WIP: Add model responses#1
KriSun95 merged 15 commits into
foxsi:mainfrom
KriSun95:add-model-responses

Conversation

@KriSun95
Copy link
Copy Markdown
Contributor

@KriSun95 KriSun95 commented Sep 16, 2025

Still tidying up a lot of the response code.

First addition is the atmospheric transmission code from @mstores98 . The new function att_atmosphere loads in the file and extracts the wanted information. The plotting function asset_atm produces the following figure:
atmospheric-transmissions
which can be found in the repository assets folder.

I (@KriSun95 ) will keep working on this PR.

  • Atmospheric code
  • Better tracking of information as the functions are being used (now using data classes)
  • Version control of code and files
  • convertible into FITS products
  • Guide and examples on the repository

@mstores98, can I request that the atmospheric file be edited such that:

  • The units for the energy field in the header is changed from keV to eV
  • The time field is provided with values in the extension similar to the energy field so the time values don't have to be hard coded into the loading function.

@KriSun95
Copy link
Copy Markdown
Contributor Author

I've updated the figure
atmospheric-transmissions

@KriSun95
Copy link
Copy Markdown
Contributor Author

@thanasipantazides @mstores98

Good point to merge before this gets much bigger!!

I'll open an Issue to track the changes still to come.

@KriSun95 KriSun95 mentioned this pull request Sep 23, 2025
6 tasks
@KriSun95 KriSun95 merged commit 4920db8 into foxsi:main Sep 23, 2025
@KriSun95 KriSun95 deleted the add-model-responses branch September 23, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant