Generate id's with custom length and letters#48
Merged
elementbound merged 9 commits intofoxssake:mainfrom Nov 28, 2023
Merged
Conversation
Author
|
Need to test it locally and build it, will wait for the docker change to be merged so it's easier to build. |
elementbound
left a comment
elementbound
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some suggestions.
|
FYI this will be a "feat" commit as it adds a new feature. Please bump the minor component in package.json. |
elementbound
approved these changes
Nov 28, 2023
elementbound
left a comment
elementbound
left a comment
There was a problem hiding this comment.
lgtm, thanks for bearing with the comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Description
I want to be able to generate id's with smaller length(eg 4-5) and a shorter alphabet
☑️ Checklist
🔗 Related issues
#44