feat(js): Handle ingestion errors in Reactor#83
Merged
elementbound merged 6 commits intofoxssake:mainfrom Nov 26, 2025
Merged
Conversation
This is a fix for crashing when sending bad data over TCP. Likely the proper fix is to swap to exceptions, and process them OR pass them to an error handler. ```bash # 1 run netcat nc localhost 9980 # 2 send bad data /213/213.23.12/.3421 # 3 no crash with this fix, or crash without the fix ```
Contributor
Author
|
Made as a draft for @elementbound to take a look in morning. |
elementbound
changed the title
elementbound
added a commit
to foxssake/nohub
that referenced
this pull request
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for crashing when sending bad data over TCP.
Likely the proper fix is to swap to exceptions, and process them OR pass them to an error handler.