Skip to content

Refactor NetBSD's ProcessTable_goThroughEntries().#1

Closed
fraggerfox wants to merge 1 commit intofix-netbsd-buildfrom
netbsd-refactor-scanprocs
Closed

Refactor NetBSD's ProcessTable_goThroughEntries().#1
fraggerfox wants to merge 1 commit intofix-netbsd-buildfrom
netbsd-refactor-scanprocs

Conversation

@fraggerfox
Copy link
Copy Markdown
Owner

Simplify the ProcessTable_goThroughEntries() and also apply the fixes for the compiler warning.

netbsd/NetBSDProcessTable.c: In function 'NetBSDProcessTable_scanProcs':
netbsd/NetBSDProcessTable.c:185:53: warning: comparison is always true due to limited range of data type [-Wtype-limits]
          const char* name = ((int64_t)kproc->p_tdev != (int64_t)KERN_PROC_TTY_NODEV) ? devname(kproc->p_tdev, S_IFCHR): NULL;

The fix came in as part of the discussion here.

Comment thread netbsd/NetBSDProcessTable.c Outdated
@fraggerfox fraggerfox force-pushed the netbsd-refactor-scanprocs branch from eda88b9 to eb568d9 Compare January 6, 2024 14:16
@fraggerfox
Copy link
Copy Markdown
Owner Author

Closed, since the commit was cherry picked into htop-dev#1360

@fraggerfox fraggerfox closed this Jan 7, 2024
@fraggerfox fraggerfox deleted the netbsd-refactor-scanprocs branch January 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants